Date: Mon, 14 Apr 2014 23:00:26 +0000 From: "Sergey A. Osokin" <osa@FreeBSD.org> To: Steven Hartland <killing@multiplay.co.uk> Cc: FreeBSD Ports <ports@freebsd.org>, Scot Hetzel <swhetzel@gmail.com>, David Keller <david.keller@litchis.fr> Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2 Message-ID: <20140414230026.GC30049@FreeBSD.org> In-Reply-To: <2DD63F83581C4EDF865148915D3D3546@multiplay.co.uk> References: <CAFop7TnRM9vUmf02jiLJLJfgOOT3B80SoM0%2BLZAfA46YPHkPvA@mail.gmail.com> <2BEF3638517B4186953121B366A7AACF@multiplay.co.uk> <20140411222748.GD67075@FreeBSD.org> <25B22ADA9DF3473CB7A433EC9394D8FE@multiplay.co.uk> <CACdU%2Bf-HKC8r%2BAisMPrQJ09YRNcQ1Kw7pcUSSoC0u9GRzypfgA@mail.gmail.com> <20140413021330.GE67075@FreeBSD.org> <CAFop7TkVXHrvnf0L7x3BUMdJnkh8H8Nz2u075Od0v5rPYg%2BG5w@mail.gmail.com> <2DD63F83581C4EDF865148915D3D3546@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Steven,
unfortunately, your patch is wrong and this is why I can't commit your changes.
What's wrong in your patch? You have mixed features and bugfixes in one patch.
Please provide bugfix only patch.
--
ozz
On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:
> ----- Original Message ----- From: "David Keller" <david.keller@litchis.fr>
>
>
> >Hi Sergey,
> >
> >It's not related to gem dependency error but the symlink creation
> >might be incorrect:
> >${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >
> >Will create the following symlink:
> >/usr/local/lib/ruby/gems/1.9/gems/passenger ->
> >lib/ruby/gems/1.9/gems/passenger-4.0.41
> >
> >Rather than:
> >/usr/local/lib/ruby/gems/1.9/gems/passenger ->
> >/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
> >
> >Or:
> >/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
> >
> >
> >You might prefer using:
> >${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
> >${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >
> >Or even:
> >${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>
> My current version has:
> (cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_NAME} ${PORTNAME})
>
> Which I will create:
> /usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
>
> @Sergey: For your apache module problem try the attached patch / full
> version which fixes that for me.
>
> I'd previously only ever built the nginx version and looks like the
> apache2 module build was broken when stage support was added.
>
> I've confirmed it builds but I don't have an apache2 install to test
> fully with here so if you could let me know if it works and I'll get all
> the changes checked in.
>
> Regards
> Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140414230026.GC30049>