Date: Tue, 19 Sep 2006 02:50:15 +0400 From: Ruslan Ermilov <ru@FreeBSD.org> To: "Christian S.J. Peron" <csjp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Jung-uk Kim <jkim@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <20060918225015.GC20647@rambler-co.ru> In-Reply-To: <450F1EC1.4060106@FreeBSD.org> References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <450F1EC1.4060106@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--PuGuTyElPB9bOcsM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2006 at 05:33:37PM -0500, Christian S.J. Peron wrote: > Jung-uk Kim wrote: > >jkim 2006-09-18 22:18:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c=20 > > Log: > > Do not strip VLAN tag in promiscuous mode. > > =20 > > Revision Changes Path > > 1.148 +28 -15 src/sys/dev/bge/if_bge.c > > > > > > =20 > I don't think this is right. An interface does not have to be in=20 > promiscuous mode in order to have BPF peers attached to it. If this is=20 > being done to ensure that vlan info is preserved for things like=20 > tcpdump, the correct fix is to use bpf_peers_present() instead. >=20 > This issue has been discussed between myself, jhb, and andre for a=20 > couple of days now. The correct fix is to teach bpf to look at the mbuf= =20 > and re-construct and insert the vlan tags before passing it through=20 > bpf_filter (and on to any peers), assuming the hardware is handling=20 > stripping and inserting vlan tags. I have agreed to work on this, time=20 > permitting. >=20 I have a patch that does this, but it's far away from me on a powered off computer. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --PuGuTyElPB9bOcsM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFDyKnqRfpzJluFF4RArdsAJ4r0+EiaQwbaWdcpCGUxhJPmOhj9wCePeBu bcZojLkfsg6Fowo2k/o9v+Q= =APpH -----END PGP SIGNATURE----- --PuGuTyElPB9bOcsM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060918225015.GC20647>