Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Feb 2017 19:51:27 +0000 (UTC)
From:      Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r314361 - stable/11/sys/dev/atkbdc
Message-ID:  <201702271951.v1RJpRYY040293@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gonzo
Date: Mon Feb 27 19:51:27 2017
New Revision: 314361
URL: https://svnweb.freebsd.org/changeset/base/314361

Log:
  MFC r313757:
  
  [psm] Fix calculation for clickpad softbuttons at the top
  
  On laptops like the ThinkPad X240, ClickPad buttons are located at the
  top. The hw.psm.synaptics.softbuttons_y sysctl was supposed to allow this
  by setting the value to a negative one (e.g. -1700). However, the
  condition was wrong (double negative), and doing that placed the buttons
  in an unreachable area.
  
  PR:		216342
  Submitted by:	Greg V <greg@unrelenting.technology>

Modified:
  stable/11/sys/dev/atkbdc/psm.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/atkbdc/psm.c
==============================================================================
--- stable/11/sys/dev/atkbdc/psm.c	Mon Feb 27 19:46:27 2017	(r314360)
+++ stable/11/sys/dev/atkbdc/psm.c	Mon Feb 27 19:51:27 2017	(r314361)
@@ -3194,7 +3194,7 @@ psmgestures(struct psm_softc *sc, finger
 		if (sc->synhw.capClickPad && ms->button & MOUSE_BUTTON1DOWN) {
 			y_ok = sc->syninfo.softbuttons_y >= 0 ?
 			    start_y < sc->syninfo.softbuttons_y :
-			    start_y > max_y - sc->syninfo.softbuttons_y;
+			    start_y > max_y + sc->syninfo.softbuttons_y;
 
 			center_button = MOUSE_BUTTON2DOWN;
 			center_x = sc->syninfo.softbutton2_x;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702271951.v1RJpRYY040293>