Date: Wed, 8 Oct 2014 14:42:22 +0000 From: "Pokala, Ravi" <rpokala@panasas.com> To: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: Seeking reviewers for patch; PR 193873 Message-ID: <D05943F7.11EE9C%rpokala@panasas.com>
next in thread | raw e-mail | index | archive | help
-----Original Message----- >Date: Mon, 6 Oct 2014 14:20:12 +0000 >From: "Meyer, Conrad" <conrad.meyer@isilon.com> >To: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> >Subject: Seeking reviewers for patch; PR 193873 >Message-ID: > <A3CAF0E84A34A540B4C74454358E003F2E4EF90D@MX103CL02.corp.emc.com> >Content-Type: text/plain; charset=3D"us-ascii" > >Hi all, > >The patch[0] dedupes dumpsys() somewhat, leaving MD-specific support code >for a few things (map/unmap a region, flush CPU writeback cache, iterate >physmem segments). > >jhibbits@ is taking a look, but he'd like another pair of eyeballs. The >more, the merrier! If someone could throw the latest patch up in >phabricator for discussion, that would be awesome. > >I'll also need someone willing to commit it, I'm not a committer. > >Questions/concerns/feedback? Hi Conrad, As mentioned in another thread ([1], [2]), I'm looking at dumping on systems w/ AF-4Kn drives (on a fairly old version of FreeBSD). Unfortunately, I'm not at all familiar w/ the process. I'm going to pick at it a few more days, but will probably end up having to punt and dumpsys onto a 512n or AF-512e device. But, since you are refactoring all this code in -CURRENT anyway, I think it would be awesome if you could look to the future and make it work w/o assuming that dump device block size is DEV_BSIZE; it would be better to use the sector size, as returned (for example) by ioctl(DIOCGSECTORSIZE). That won't help me now, but hopefully it will help everyone in the future. Thanks, Ravi [1]:=20 https://lists.freebsd.org/pipermail/freebsd-hackers/2014-September/046164.h tml [2]:=20 https://lists.freebsd.org/pipermail/freebsd-hackers/2014-October/046181.htm l >Thanks, >Conrad > >[0]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D193873
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D05943F7.11EE9C%rpokala>