Date: Sun, 12 Feb 2017 18:33:27 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Cy Schubert <Cy.Schubert@komquats.com> Cc: George Neville-Neil <gnn@neville-neil.com>, Ermal =?iso-8859-1?Q?Lu=E7i?= <eri@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313675 - in head/sys: netinet netinet6 Message-ID: <20170212183327.GA2002@FreeBSD.org> In-Reply-To: <201702121624.v1CGOQGr009733@slippy.cwsent.com> References: <gnn@neville-neil.com> <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com> <201702121624.v1CGOQGr009733@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2017 at 08:24:26AM -0800, Cy Schubert wrote: > In message <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com>, "Geor= ge Neville-Neil" writes: > > This is an OpenPGP/MIME signed message (RFC 3156 and 4880). > > On 12 Feb 2017, at 6:10, Glen Barber wrote: > > > On Sun, Feb 12, 2017 at 06:56:33AM +0000, Ermal Lu=3DC3=3DA7i wrote: > > >> Author: eri > > >> Date: Sun Feb 12 06:56:33 2017 > > >> New Revision: 313675 > > >> URL: https://svnweb.freebsd.org/changeset/base/313675 > > >> > > >> Log: > > >> Committed without approval from mentor. > > >> > > >> Reported by: gnn > > >> > > > > > > What exactly does this mean? > > > > >=20 > > Ermal took the Acceptance on reviews.freebsd.org by Adrian as an implic= it > > "go ahead" to commit to the tree. The issue is that he's still under > > mentorship, by me, and had not gotten an approval or had an Approved by: > > line. I asked him to revert the change himself. > >=20 > > We're working out a few more issues in the review now. >=20 > I didn't read this when I hit send on my email. Hopefully nobody takes=20 > offense. I was upset and still am. >=20 > I still think that the revision numbers of any backout should have been= =20 > documented in the commit log. >=20 I absolutely agree, and was the key meaning behind my "what exactly does this mean?" reply. The commit log, as-is, provides nothing useful to the reader. > Something we could do, as is expected by re@ for commits during a freeze,= =20 > is metees also let their mentors know of what the contents of commit log= =20 > messages will be. I think commit log messages discussing the what, why an= d=20 > rationale are as important as the code itself. >=20 I thought this was standard practice. But if not, I would agree that both code changes and the commit log should be both approved by the mentor. Just my $0.02 USD. Glen --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYoKp3AAoJEAMUWKVHj+KT3r4QAIdk1B4dmyWp3GzCMPCA4FE6 3U/ZXHb/lh8TublcxTQNmDwp4qejb7BbKcJh8cxSGZTfDnpMfLOzwuGIAQlcx2+/ Vu3vEbrOILjFTHyIZqgdCJNVVffvm6C74SZwejkB4IoFZtvF95uKO2NFzysdQekA FMFshSxtBTU0R5gjfk3TaXy7xalk5ySiGkCHZMTmpbRjtlUHn7qTAxPUWIKgTH0l YreV1Pjke0xybfd2w3zKNmVJ8MNOzeuCvx1vVgjtaEEexxi5AEY764vZ8CXae8qg CFNKX0UO4FzBs5hxxt3wWe04jcAKwRx6cgJ467GPO65gkOZdu8dnKWDODuYaEqrp hKqhYQUK4I9YI5i8wW3bqaSTU3kGYQxUqlHT3tbd5HvKTUOIVnCGCl9yZ3mpOg3d gDnmoNq8AnsxE24IgRmbcjQEUeST1RKPG8J9qOtIpU0P4oOJMBC+vh5YkqQG9tMi PaXNDYSA2PQY/FBmYyalTMPQLDPmNIjjAEwBqukDxyMMPUvvuHgHaLZLIQO4wlAR 3/nfjyb6xLxJsG12yD8kQVmGYC8v5c2RczqTeGneDm30MCKzCqxKHslabjLOdlzm pC5q30seZrYgUX2jL+hdqV3I/473FbaQBMkiVSG2B6pwjI/hP4GIxq+GGvTiZH6T 13ey0qQbFK6N8NqeaxyM =gnIr -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170212183327.GA2002>