Date: Sat, 17 Dec 2016 17:51:08 -0700 From: Adam Weinberger <adamw@adamw.org> To: marino@freebsd.org Cc: Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r428809 - head/irc/ircII Message-ID: <2A9B1D74-30D8-4DB5-B748-C109C032CF45@adamw.org> In-Reply-To: <03711abb-01fd-274d-2a08-50c76cd162c2@marino.st> References: <201612172230.uBHMUkAo015155@repo.freebsd.org> <03711abb-01fd-274d-2a08-50c76cd162c2@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 17 Dec, 2016, at 17:30, John Marino <freebsd.contact@marino.st> = wrote: >=20 > On 12/17/2016 16:30, Adam Weinberger wrote: >> Author: adamw >> Date: Sat Dec 17 22:30:45 2016 >> New Revision: 428809 >> URL: https://svnweb.freebsd.org/changeset/ports/428809 >>=20 >> Log: >> Fix build against SSL from ports. The -L${ICONV_PREFIX}/lib prevents >> cc from finding the correct libcrypto/libssl, so quick-fix this by >> only adding -L${ICONV_PREFIX}/lib if it's something other than = /usr/lib. >>=20 >> Also, use USES=3Dssl. PORTREVISION bump for the potential ldd = change. >>=20 >> Modified: >> head/irc/ircII/Makefile >>=20 >> Modified: head/irc/ircII/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/irc/ircII/Makefile Sat Dec 17 21:54:49 2016 = (r428808) >> +++ head/irc/ircII/Makefile Sat Dec 17 22:30:45 2016 = (r428809) >> @@ -3,6 +3,7 @@ >>=20 >> PORTNAME=3D ircii >> PORTVERSION=3D 20151120 >> +PORTREVISION=3D 1 >> CATEGORIES=3D irc ipv6 >> MASTER_SITES=3D http://ircii.warped.com/ >>=20 >> @@ -23,7 +24,7 @@ IRCBUG_DESC=3D Install ircII bug-reporting >> EMACS_KEYS_DESC=3DUse emacs meta keys >>=20 >> EMACS_KEYS_CONFIGURE_WITH=3D emacs-meta-keys >> -OPENSSL_USE=3D OPENSSL=3Dyes >> +OPENSSL_USES=3D ssl >>=20 >> .include <bsd.port.pre.mk> >>=20 >> @@ -33,8 +34,10 @@ CONFIGURE_ARGS+=3D --with-openssl=3D${OPENSS >> CONFIGURE_ARGS+=3D --without-openssl >> .endif >>=20 >> +.if ${ICONV_PREFIX} !=3D /usr >> CPPFLAGS+=3D -I${ICONV_PREFIX}/include >> LDFLAGS+=3D -L${ICONV_PREFIX}/lib >> +.endif >>=20 >> post-patch: >> @${REINPLACE_CMD} -e '/^mandir =3D/s/@mandir@/$${DESTDIR}&/' \ >>=20 >=20 > I don't think ICONV_PREFIX is a factor. > You probably just need: > OPENSSL_CPPFLAGS=3D -I${OPENSSLINC} > OPENSSL_LDFLAGS=3D -L${OPENSSLLIB} >=20 > Try removing what you added and use these option helpers instead. > John Thanks, John. That ICONV_PREFIX kludge definitely felt all wrong. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2A9B1D74-30D8-4DB5-B748-C109C032CF45>