Date: Mon, 18 Nov 2002 23:06:17 -0800 (PST) From: Nate Lawson <nate@root.org> To: Jake Burkholder <jake@FreeBSD.org> Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/sys/dev/sab sab.c Message-ID: <Pine.BSF.4.21.0211182256530.59456-100000@root.org> In-Reply-To: <20021117160343.6D41037B498@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Modified files: > sys/dev/sab sab.c > Log: > - Add support for ALT_BREAK_TO_DEBUGGER; this is the only reliable way > to trigger a breakpoint with this chip. When I put together the GDB_AUTO_ENTER patch, I made a decision to abstract out the state machine. You pass it a char and it returns 1 if it has reached a match or zero otherwise. If multiple state machines were needed (say sio + sab) then the caller would pass in static storage for the state (say from the softc). Since you've duplicated the ALT_BREAK_TO_DEBUGGER state machine now, it should probably get moved into its own function as well. One question I had was where such state machines should go. Since they're dependent on DDB, I put mine in db_trap.c. Ideas? I think this is a useful move since there are UDP-based gdb stubs as well. -Nate (Patch at http://www.root.org/~nate/freebsd) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0211182256530.59456-100000>