Date: Tue, 23 Mar 2010 01:35:47 +0000 (UTC) From: Juli Mallett <jmallett@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r205501 - user/jmallett/octeon/sys/mips/mips Message-ID: <201003230135.o2N1ZlMI004501@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jmallett Date: Tue Mar 23 01:35:46 2010 New Revision: 205501 URL: http://svn.freebsd.org/changeset/base/205501 Log: Attempt to cast address-checking into some semblance of validity. Modified: user/jmallett/octeon/sys/mips/mips/db_trace.c Modified: user/jmallett/octeon/sys/mips/mips/db_trace.c ============================================================================== --- user/jmallett/octeon/sys/mips/mips/db_trace.c Tue Mar 23 01:27:59 2010 (r205500) +++ user/jmallett/octeon/sys/mips/mips/db_trace.c Tue Mar 23 01:35:46 2010 (r205501) @@ -184,7 +184,7 @@ loop: } /* check for bad PC */ /*XXX MIPS64 bad: These hard coded constants are lame */ - if (pc & 3 || pc < (uintptr_t)0x80000000 || pc >= (uintptr_t)edata) { + if (pc & 3 || (uintptr_t)pc < 0x80000000u || (uintptr_t)pc >= (uintptr_t)edata) { (*printfn) ("PC 0x%x: not in kernel\n", pc); ra = 0; goto done;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003230135.o2N1ZlMI004501>