Date: Thu, 1 Feb 2001 17:25:52 +0200 From: Peter Pentchev <roam@orbitel.bg> To: FUJISHIMA Satsuki <sf@FreeBSD.org> Cc: ports@FreeBSD.org Subject: Re: call for review: portlint Message-ID: <20010201172552.F718@ringworld.oblivion.bg> In-Reply-To: <86zog6a2mb.wl@cheerful.com>; from sf@FreeBSD.org on Thu, Feb 01, 2001 at 11:39:56PM %2B0900 References: <86zog6a2mb.wl@cheerful.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 01, 2001 at 11:39:56PM +0900, FUJISHIMA Satsuki wrote: > Currently portlint points "unnecessary blank line at the last part" > warning for many files/patch-*, but this warning is unnecessary. Those > patches made with diff -u sometimes includes some '0x20\n' at the end > of file. > > This patch is to ignore such a patch files. I'm going to commit this > in a few days if no one have object. Actually, this patch does not quite DTRT. portlint should not check patchfiles for empty lines at all - some versions of patch(1) might need the context. Originally, portlint did not check patchfiles for empty lines at the end, but this was somewhat broken with the ports tree restructuring at the end of last year. I submitted a simple patch a while ago, which is attached to this message, too; however, the Michael Haro, the portlint author, said that there's not all that much point in minor fixes to this portlint, when the new portlint's drawing near: http://www.freebsd.org/~mharo/portlint3/ G'luck, Peter -- If wishes were fishes, the antecedent of this conditional would be true. Index: ports/devel/portlint/src/portlint.pl =================================================================== RCS file: /home/ncvs/ports/devel/portlint/src/portlint.pl,v retrieving revision 1.24 diff -u -r1.24 portlint.pl --- ports/devel/portlint/src/portlint.pl 2000/12/12 14:24:12 1.24 +++ ports/devel/portlint/src/portlint.pl 2000/12/12 15:20:34 @@ -97,7 +97,7 @@ } -getopts('abchtvBM:N:V'); +getopts('abchtvB:M:NV'); &usage if $opt_h; &version if $opt_V; @@ -274,7 +274,7 @@ } else { my $proc = $checker{$i}; &$proc($i) || &perror("Cannot open the file $i\n"); - if ($i !~ /^files\/patch-/) { + if ($i !~ m@/files/patch-@) { &checklastline($i) || &perror("Cannot open the file $i\n"); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010201172552.F718>