Date: Fri, 2 Dec 2011 21:06:42 +0530 From: "Jayachandran C." <jchandra@freebsd.org> To: freebsd-sparc64@freebsd.org Cc: marius@freebsd.org Subject: Re: [PATCH] fix OF_finddevice return value checks on sparc64 Message-ID: <CA%2B7sy7AQ5R7tNwydtsC6Hb3Yk8_aRM4Titb20B=JFnQy5Z-OXw@mail.gmail.com> In-Reply-To: <CA%2B7sy7B41x0izHhgHLGDFutSUr3y0dCYPnj3tnVfcYfeprhpLQ@mail.gmail.com> References: <CA%2B7sy7B41x0izHhgHLGDFutSUr3y0dCYPnj3tnVfcYfeprhpLQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 2, 2011 at 7:05 PM, Jayachandran C. <jchandra@freebsd.org> wrot= e: > While going thru the OF_finddevice usage in kernel (to fix up the FDT > interface) I noticed that =A0a few calls made to OF_finddevice in > sparc64 does not check the return value correctly. > > The error return is -1 not 0, and since the value is unsigned, > checking it for '< 0' does not work either. =A0The attached patch fixes > this. I had not planned to commit this yet, but it has gone in with the related changes in r228201. Let me know if there are any objections - I can revert or check in further changes if needed. Thanks, JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B7sy7AQ5R7tNwydtsC6Hb3Yk8_aRM4Titb20B=JFnQy5Z-OXw>