Date: Sun, 28 Nov 2010 15:26:24 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases Makefile ports/databases/py-flask-sqlalchemy Makefile distinfo pkg-descr pkg-plist Message-ID: <20101128152624.GB717@FreeBSD.org> In-Reply-To: <201011270201.oAR21awa042310@repoman.freebsd.org> References: <201011270201.oAR21awa042310@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 27, 2010 at 02:01:36AM +0000, Philip M. Gollucci wrote: > pgollucci 2010-11-27 02:01:35 UTC > > FreeBSD ports repository > > Modified files: > databases Makefile > Added files: > databases/py-flask-sqlalchemy Makefile distinfo pkg-descr > pkg-plist > Log: > Flask-SQLAlchemy adds support for SQLAlchemy to your Flask application. > > WWW: http://pypi.python.org/pypi/Flask-SQLAlchemy > > PR: ports/151626 > Submitted by: Olivier Duchateau <duchateau.olivier at gmail.com> - Makefile is severely unindented - PORTNAME is just disgustingly non-FreeBSDish [*] - COMMENT should not be based on a verb instead of noun - Missing tab in second RUN_DEPENDS line - LICENSE should be better placed after COMMENT - Port description contains style bug (tab after WWW:) and is identical to comment, ergo useless [*] Original submission (which I've reviwed) did not contain this bug. Why did you introduce it? Please fix. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101128152624.GB717>