Date: Thu, 17 Mar 2011 10:17:32 +0100 From: Matthias Andree <mandree@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/gpart Makefile distinfo ports/sysutils/gpart/files patch-ae patch-af Message-ID: <4D81D1AC.1020705@FreeBSD.org> In-Reply-To: <20110317070735.GA50416@FreeBSD.org> References: <201103170003.p2H03lCu061081@repoman.freebsd.org> <20110317070735.GA50416@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 17.03.2011 08:07, schrieb Alexey Dokuchaev: > On Thu, Mar 17, 2011 at 12:03:47AM +0000, Matthias Andree wrote: >> mandree 2011-03-17 00:03:47 UTC >> >> Modified files: >> sysutils/gpart Makefile distinfo >> Added files: >> sysutils/gpart/files patch-ae patch-af >> Log: >> First round of amd64 fixes. Compiles and detects BSD partitions, but >> may require work for NTFS, NTFS5, or other partitions. [...] >> >> Revision Changes Path >> 1.16 +7 -6 ports/sysutils/gpart/Makefile >> 1.9 +0 -1 ports/sysutils/gpart/distinfo >> 1.1 +34 -0 ports/sysutils/gpart/files/patch-ae (new) >> 1.1 +96 -0 ports/sysutils/gpart/files/patch-af (new) > > Perhaps you could explain why did you decide to go with legacy patch > naming scheme when it is clearly advised to be avoided by PH? Alexey, I do appreciate your eyeballs on my commits, the German saying is that four eyes see more than two, and I do subscribe to QA and code reviews in general. But perhaps you can save us all a bit of work by skimming through later commit messages, too, where you would have seen that I'd rectified that before you'd posted your question :-) The answer was "patch ordering". I needed to sort out two-patches-for-one-file (also not in line with the porter's conventions). That broke with "make makepatch". combinediff came to the rescue. (Is there a CVS-based tool for the add-added-and-remove-removed-files task that, for instance, SVN's loaddirs or Git's subcommands can do?) Best regards -- Matthias Andree ports committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D81D1AC.1020705>