Date: Fri, 4 Jun 2004 23:08:41 +0200 From: Maxime Henrion <mux@freebsd.org> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <20040604210841.GL9228@elvis.mu.org> In-Reply-To: <20040603011904.GB714@xor.obsecurity.org> References: <200406022252.i52MqJFp094240@repoman.freebsd.org> <20040603011904.GB714@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote: > On Wed, Jun 02, 2004 at 03:52:18PM -0700, Maxime Henrion wrote: > > mux 2004/06/02 15:52:18 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/fxp if_fxp.c if_fxpvar.h > > Log: > > Use the device sysctl tree instead of rolling our own. Some of the > > sysctls were global (hw.fxp_rnr and hw.fxp_noflow), all of them are > > now per-device. Sample output of "sysctl dev.fxp0" with this patch, > > with the standard %foo nodes removed : > > > > dev.fxp0.int_delay: 1000 > > dev.fxp0.bundle_max: 6 > > dev.fxp0.rnr: 0 > > dev.fxp0.noflow: 0 > > What are your thoughts about making noflow the default? Having an fxp > machine panic and DoS an entire network is not friendly. I'm not opposed to that. I'd like to hear rwatson confirming this since he's the one who implemented that sysctl, but I think it is fairly safe. Cheers, Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040604210841.GL9228>