Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 May 2004 01:25:59 -0600
From:      Scott Long <scottl@freebsd.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/pci pci.c
Message-ID:  <40ADAF07.2070909@freebsd.org>
In-Reply-To: <200405210636.i4L6aadV059034@repoman.freebsd.org>
References:  <200405210636.i4L6aadV059034@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote:
> imp         2004/05/20 23:36:36 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/pci          pci.c 
>   Log:
>   MFp4: o save/restore subvendor, subdevice, vendor, device, baseclass,
>           subclass, progif and revid.  While these are typically read
>           only fields, they aren't always read-only.  progif is writable
>           for ata devices, for example.  It does no harm when they are
>           read only, and helps when they aren't.
>   
>   Revision  Changes    Path
>   1.252     +16 -0     src/sys/dev/pci/pci.c

Shouldn't it be left up to the device drivers to decide if a buggy piece
of silicon needs to be touched like this?  I really don't like the bus
unilaterally enforcing this on everything.

Scott



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40ADAF07.2070909>