Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 May 2009 16:09:08 GMT
From:      Vladimir Chukharev <chukharev@mail.ru>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/135095: [patch] ports-mgmt/portlint should check for a.out filename
Message-ID:  <200905311609.n4VG97dC025372@www.freebsd.org>
Resent-Message-ID: <200905311610.n4VGA1LJ004345@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         135095
>Category:       ports
>Synopsis:       [patch] ports-mgmt/portlint should check for a.out filename
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 31 16:10:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Vladimir Chukharev
>Release:        7.2-STABLE
>Organization:
>Environment:
FreeBSD chu.me.tut.fi 7.2-STABLE FreeBSD 7.2-STABLE #0: Sat May  9 00:01:08 EEST 2009     root@chu.me.tut.fi:/usr/obj/usr/src/sys/CHU  i386

>Description:
This PR is a follow-up to ports/131790 and related to conf/129697.

As reported in ports/131790, some files are deleted if periodic.conf has
daily_clean_disks_enable="YES". The full list of pattens for removing is
defined in /etc/defaults/periodic.conf as
daily_clean_disks_files="[#,]* .#* a.out *.core *.CKP .emacs_[0-9]*"

ports/131790 was closed after a check for *.core was added. The attached patch
add a check for files named "a.out". The lang/sbcl port installs two files with 
this name.

I am not proficient in pattern matching and perl, so I do not even try to fix 
portlint for all the list of patterns.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- ports-mgmt/portlint/src/portlint.pl.orig	2009-05-31 18:20:09.000000000 +0300
+++ ports-mgmt/portlint/src/portlint.pl	2009-05-31 18:20:09.000000000 +0300
@@ -831,6 +831,13 @@
 				"If possible, install this file with a different name.");
 		}
 
+		if ($_ =~ m|/a.out$| && $_ !~ /^\@/) {
+			&perror("WARN", $file, $., "this port installs a file named ".
+				"\"a.out\".  This file may be deleted if ".
+				"daily_clean_disks_enable=\"YES\" in /etc/periodic.conf.  ".
+				"If possible, install this file with a different name.");
+		}
+
 		if ($autoinfo && $_ =~ /\.info$/) {
 			&perror("WARN", $file, $., "enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.");
 		}


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905311609.n4VG97dC025372>