Date: Tue, 10 Aug 2010 18:54:41 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Josh Paetzel <jpaetzel@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Richard Neese <r.neese@gmail.com>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/freeswitch-core Makefile pkg-plist ports/net/freeswitch-core/files freeswitch.in Message-ID: <4C6202E1.4010209@FreeBSD.org> In-Reply-To: <201008110139.o7B1dIR8053761@repoman.freebsd.org> References: <201008110139.o7B1dIR8053761@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------060302060206000504050303 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit In addition to the plist issues you also made a change to the rc.d file, but you didn't go far enough. :) There are numerous issues with the existing file: 1. It's generally preferred that ports rc.d files use REQUIRE: LOGIN unless there is a good reason not to. However this service runs as an unprivileged user, which makes that a requirement. 2. The default variable assignments have to come after load_rc_config to be effective. 3. _flags should not be reproduced in command_args 4. The start and restart methods seem superfluous to me, most if not all of what you're going for can likely be accomplished by using wait_for_pids in the _stop method. The attached patch should accomplish these fixes, but it should be tested of course ... Doug On 08/10/2010 18:39, Josh Paetzel wrote: > jpaetzel 2010-08-11 01:39:18 UTC > > FreeBSD ports repository > > Modified files: > net/freeswitch-core Makefile pkg-plist > net/freeswitch-core/files freeswitch.in > Log: > Fix issues with plist caused by previous commit. > Remove BROKEN > > PR: ports/149119 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=149119 > Submitted by: Richard Neese <r.neese@gmail.com> > > Revision Changes Path > 1.8 +43 -36 ports/net/freeswitch-core/Makefile > 1.3 +2 -2 ports/net/freeswitch-core/files/freeswitch.in > 1.3 +202 -200 ports/net/freeswitch-core/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/freeswitch-core/Makefile.diff?&r1=1.7&r2=1.8&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/freeswitch-core/files/freeswitch.in.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/freeswitch-core/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso --------------060302060206000504050303 Content-Type: text/plain; name="freeswitch-rcd.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="freeswitch-rcd.diff" SW5kZXg6IGZyZWVzd2l0Y2guaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvcGN2 cy9wb3J0cy9uZXQvZnJlZXN3aXRjaC1jb3JlL2ZpbGVzL2ZyZWVzd2l0Y2guaW4sdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMwpkaWZmIC11IC1yMS4zIGZyZWVzd2l0Y2guaW4KLS0tIGZy ZWVzd2l0Y2guaW4JMTEgQXVnIDIwMTAgMDE6Mzk6MTcgLTAwMDAJMS4zCisrKyBmcmVlc3dp dGNoLmluCTExIEF1ZyAyMDEwIDAxOjUxOjQ4IC0wMDAwCkBAIC0xLDggKzEsNyBAQAogIyEv YmluL3NoCiAKICMgUFJPVklERTogZnJlZXN3aXRjaAotIyBSRVFVSVJFOiBEQUVNT04KLSMg QkVGT1JFOiBMT0dJTgorIyBSRVFVSVJFOiBMT0dJTgogIyBLRVlXT1JEOiBzaHV0ZG93bgog IwogIyBBZGQgdGhlIGZvbGxvd2luZyBsaW5lcyB0byAvZXRjL3JjLmNvbmYgdG8gZW5hYmxl IGZyZWVzd2l0Y2g6CkBAIC0xNSw1NiArMTQsMjcgQEAKIAogLiAvZXRjL3JjLnN1YnIKIAor bmFtZT1mcmVlc3dpdGNoCityY3Zhcj1gc2V0X3JjdmFyYAorCitsb2FkX3JjX2NvbmZpZyAk bmFtZQorCiBmcmVlc3dpdGNoX2VuYWJsZT0ke2ZyZWVzd2l0Y2hfZW5hYmxlOi0iTk8ifQog ZnJlZXN3aXRjaF91c2VyPSR7ZnJlZXN3aXRjaF91c2VyOi0iZnJlZXN3aXRjaCJ9CiBmcmVl c3dpdGNoX2dyb3VwPSR7ZnJlZXN3aXRjaF9ncm91cDotImZyZWVzd2l0Y2gifQogZnJlZXN3 aXRjaF9mbGFncz0ke2ZyZWVzd2l0Y2hfZmxhZ3M6LSItbmMgLXdhc3RlIn0KIAotbmFtZT1m cmVlc3dpdGNoCi1yY3Zhcj1gc2V0X3JjdmFyYAotCiBjb21tYW5kPSUlUFJFRklYJSUvYmlu L2ZyZWVzd2l0Y2gKLWNvbW1hbmRfYXJncz0iJHtmcmVlc3dpdGNoX2ZsYWdzfSAtdSAke2Zy ZWVzd2l0Y2hfdXNlcn0gLWcgJHtmcmVlc3dpdGNoX2dyb3VwfSIKK2NvbW1hbmRfYXJncz0i LXUgJHtmcmVlc3dpdGNoX3VzZXJ9IC1nICR7ZnJlZXN3aXRjaF9ncm91cH0iCiAKIHBpZGZp bGU9JHtmcmVlc3dpdGNoX3BpZGZpbGU6LSIvdmFyL3J1bi9mcmVlc3dpdGNoL2ZyZWVzd2l0 Y2gucGlkIn0KIAotc3RhcnRfY21kPSJmcmVlc3dpdGNoX3N0YXJ0Igogc3RvcF9wcmVjbWQ9 ImZyZWVzd2l0Y2hfc3RvcCIKLXJlc3RhcnRfY21kPSJmcmVlc3dpdGNoX3Jlc3RhcnQiCi0K LXNpZ19zdG9wPUtJTEwgIAotCi1sb2FkX3JjX2NvbmZpZyAkbmFtZQogCiBmcmVlc3dpdGNo X3N0b3AgKCkgewogICAgICAgICBlY2hvICJTdG9wcGluZyBGcmVlU1dJVENILiIKICAgICAg ICAgJSVQUkVGSVglJS9iaW4vZnJlZXN3aXRjaCAtc3RvcAotICAgICAgICBzbGVlcCAxCi0g ICAgICAgIHJldHVybiAwCisJd2FpdF9mb3JfcGlkcyBgY2F0ICRwaWRmaWxlYAogfQogCi1m cmVlc3dpdGNoX3N0YXJ0ICgpIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAKLSAgICAgICAgZWNobyAiU3RhcnRpbmcgRnJl ZVNXSVRDSC4iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IAotICAgICAgICAkY29tbWFuZCAkY29tbWFuZF9hcmdzCi0gICAgICAgIHNsZWVwIDEKLSAg ICAgICAgcmV0dXJuCi19Ci0KLWZyZWVzd2l0Y2hfcmVzdGFydCAoKSB7Ci0gICAgICAgIGVj aG8gIlJlc3RhcnRpbmcgRnJlZVN3aXRjaC4iCi0gICAgICAgIGZyZWVzd2l0Y2hfc3RvcCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAot ICAgICAgICBpZiBbICQ/IC1lcSAwIF07Ci0JdGhlbgotCXN0YXR1cz0kPwotCWZyZWVzd2l0 Y2hfc3RhcnQKLSAgICAgICAgc2xlZXAgMQotCXJldHVybiAwCi0JZWxzZQotCWVjaG8gIlBy b2JsZW0gc3RvcGluZyBGcmVlU1dJVENIOiAkc3RhdHVzIgotCXNsZWVwIDEKLQlyZXR1cm4g MQotCWZpCi19IAotCiBydW5fcmNfY29tbWFuZCAiJDEiCi0K --------------060302060206000504050303--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C6202E1.4010209>