Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Apr 2016 08:11:29 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Pedro Giffuni <pfg@freebsd.org>
Cc:        Bruce Evans <brde@optusnet.com.au>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r297525 - head/sys/compat/linux
Message-ID:  <20160404080837.N1636@besplex.bde.org>
In-Reply-To: <57016E2A.4060301@FreeBSD.org>
References:  <201604031440.u33EesB7057019@repo.freebsd.org> <20160404045828.M816@besplex.bde.org> <57016E2A.4060301@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 3 Apr 2016, Pedro Giffuni wrote:

> On 03/04/2016 14:11, Bruce Evans wrote:
>> On Sun, 3 Apr 2016, Pedro F. Giffuni wrote:
>> 
>>> Author: pfg
>>> Log:
>>>  Fix indentation oops.
>>> 
>>> Modified:
>>>  head/sys/compat/linux/linux_misc.c
>>> 
>>> Modified: head/sys/compat/linux/linux_misc.c
>>> ============================================================================== 
>>> --- head/sys/compat/linux/linux_misc.c    Sun Apr  3 14:38:26 2016 
>>> (r297524)
>>> +++ head/sys/compat/linux/linux_misc.c    Sun Apr  3 14:40:54 2016 
>>> (r297525)
>>> @@ -896,12 +896,12 @@ linux_utimensat(struct thread *td, struc
>>>         }
>>>         timesp = times;
>>> 
>>> -        if (times[0].tv_nsec == UTIME_OMIT &&
>>> -            times[1].tv_nsec == UTIME_OMIT)
>>>         /* This breaks POSIX, but is what the Linux kernel does
>>>          * _on purpose_ (documented in the man page for utimensat(2)),
>>>          * so we must follow that behaviour. */
>>> -        return (0);
>>> +        if (times[0].tv_nsec == UTIME_OMIT &&
>>> +            times[1].tv_nsec == UTIME_OMIT)
>>> +            return (0);
>>>     }
>>> 
>>>     if (args->pathname != NULL)
>> 
>> The comment is still not written in BSD style.
>> 
> I didn't change the original. Is it worth it to do another commit to add
> lines for a beginning and end comment delimiters ?

Not really.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160404080837.N1636>