Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jan 2013 21:50:53 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r245950 - head/sys/fs/ext2fs
Message-ID:  <201301262150.r0QLorLa066523@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Sat Jan 26 21:50:52 2013
New Revision: 245950
URL: http://svnweb.freebsd.org/changeset/base/245950

Log:
  Cosmetical off-by-one
  
  Technically, the case when all the blocks are released
  is not a sanity check.
  Move further the comment while here.
  
  Suggested by:	bde
  MFC after:	3 days

Modified:
  head/sys/fs/ext2fs/ext2_inode.c

Modified: head/sys/fs/ext2fs/ext2_inode.c
==============================================================================
--- head/sys/fs/ext2fs/ext2_inode.c	Sat Jan 26 21:29:45 2013	(r245949)
+++ head/sys/fs/ext2fs/ext2_inode.c	Sat Jan 26 21:50:52 2013	(r245950)
@@ -341,9 +341,9 @@ done:
 	 * Put back the real size.
 	 */
 	oip->i_size = length;
-	if (oip->i_blocks > blocksreleased)
+	if (oip->i_blocks >= blocksreleased)
 		oip->i_blocks -= blocksreleased;
-	else			/* sanity */
+	else				/* sanity */
 		oip->i_blocks = 0;
 	oip->i_flag |= IN_CHANGE;
 	vnode_pager_setsize(ovp, length);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301262150.r0QLorLa066523>