Date: Tue, 12 Aug 2008 16:16:56 GMT From: Sam Leffler <sam@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 147244 for review Message-ID: <200808121616.m7CGGuE8041359@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=147244 Change 147244 by sam@sam_ebb on 2008/08/12 16:16:11 add disabled code to mark where we might validate the BA window size in the ADDBA response; we don't want/need to do it now as we silently truncate values that are too large to our max Affected files ... .. //depot/projects/vap/sys/net80211/ieee80211_ht.c#33 edit Differences ... ==== //depot/projects/vap/sys/net80211/ieee80211_ht.c#33 (text+ko) ==== @@ -1508,7 +1508,19 @@ vap->iv_stats.is_addba_badpolicy++; return; } - +#if 0 + /* XXX we take MIN in ieee80211_addba_response */ + if (bufsiz > IEEE80211_AGGR_BAWMAX) { + IEEE80211_DISCARD_MAC(vap, + IEEE80211_MSG_ACTION | IEEE80211_MSG_11N, + ni->ni_macaddr, "ADDBA response", + "BA window too large: max %d, " + "received %d, tid %d code %d", + bufsiz, IEEE80211_AGGR_BAWMAX, tid, code); + vap->iv_stats.is_addba_badbawinsize++; + return; + } +#endif IEEE80211_NOTE(vap, IEEE80211_MSG_ACTION | IEEE80211_MSG_11N, ni, "recv ADDBA response: dialogtoken %u code %d "
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808121616.m7CGGuE8041359>