Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Apr 2005 23:28:26 -0400
From:      Alexander Kabaev <kabaev@gmail.com>
To:        current@FreeBSD.org
Subject:   Re: [PATCH] Allow watching of vnodes that reside on non-UFS filesystems	with kqueue
Message-ID:  <20050412232826.6c73bf0e@kan.dnsalias.net>
In-Reply-To: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org>
References:  <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 12 Apr 2005 23:05:45 -0400
Suleiman Souhlal <ssouhlal@FreeBSD.org> wrote:

> Hello,
> 
> The patch at 
> http://people.freebsd.org/~ssouhlal/testing/kqueue-hooks-20050412.diff
> 
> allows watching vnodes on non-UFS filesystems with kqueue.
> 
> It moves the VN_KNOTE calls to pre and post VOP_* hooks. These hooks 
> are currently used for VFS lock debugging only, but I made them 
> unconditional. I think that they we could eventually move the 
> mac_check_vnode_* calls into them too, with a bit of work.
> 
> I would like to commit this to HEAD, if there are no objections.

I for one am not thrilled by all the hooks being made unconditional and 
being inserted right into the middle of critical path for the benefit of
rarely used feature.
-- 
Alexander Kabaev



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050412232826.6c73bf0e>