Date: Sun, 11 Dec 2016 15:38:45 -0800 From: Hiren Panchasara <hiren@freebsd.org> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Lohith Bellad <lohith.bellad@me.com> Subject: Re: svn commit: r307745 - head/sys/kern Message-ID: <20161211233845.GE27291@strugglingcoder.info> In-Reply-To: <CAPQ4fft5M=5zMtKeTJbmwF5pBg=s7yn9RwMOyEfm-xZYujhkbw@mail.gmail.com> References: <201610211827.u9LIRUUi010303@repo.freebsd.org> <CAPQ4fft5M=5zMtKeTJbmwF5pBg=s7yn9RwMOyEfm-xZYujhkbw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--HFNNDGBA8bk+zEXz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12/10/16 at 09:35P, Oliver Pinter wrote: > On 10/21/16, Hiren Panchasara <hiren@freebsd.org> wrote: > > Author: hiren > > Date: Fri Oct 21 18:27:30 2016 > > New Revision: 307745 > > URL: https://svnweb.freebsd.org/changeset/base/307745 > > > > Log: > > Rework r306337. > > > > In sendit(), if mp->msg_control is present, then in sockargs() we are > > allocating mbuf to store mp->msg_control. Later in kern_sendit(), call > > to getsock_cap(), will check validity of file pointer passed, if this > > fails EBADF is returned but mbuf allocated in sockargs() is not freed. > > Made code changes to free the same. > > > > Since freeing control mbuf in sendit() after checking (control !=3D N= ULL) > > may lead to double freeing of control mbuf in sendit(), we can free > > control mbuf in kern_sendit() if there are any errors in the routine. > > > > Submitted by: Lohith Bellad <lohith.bellad@me.com> > > Reviewed by: glebius > > MFC after: 3 weeks > > Differential Revision: https://reviews.freebsd.org/D8152 >=20 > Hi Hiren! >=20 > What's the status of the MFC? I not see them (this and r306337) in > 11-STABLE nor in 10-STABLE branch. Thanks for the reminder. I MFCd to 11. I don't really track 10 anymore so I'd request you to do it yourself. If you can't for some reason, let me know. Cheers, Hiren --HFNNDGBA8bk+zEXz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJYTeOCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lPdEH/Rk0RsAfnkmJo7ZgR7nVOmHq 75oEzq8VzcwcmagJH9G1tx1TnisOdOlrUrJk6S741/GA3N22AQjtBhJTtqqX+HFV 0iNH1+QcincKPD654WDhLUeRfl3oD1LjYUit9lCuN45TECzYu/nh2kReQACrLIje oqskPorMx07TVV40DoB8axGIDEp2xA1pPFUa5BMQvnwLcA2xv+Tx8Gk0oKSzofrk x02Fk/7NWqxZHqhgH9l3PZMqu2aeN1554omoF820YKtSCqGIKi6U/eVq2j95IVGu vaI5UsrFae9J6/wKFKy/qZRVzE5uwY7TE8KRjVETZ1PbGP4Meg8CdejYsBxixkM= =qkad -----END PGP SIGNATURE----- --HFNNDGBA8bk+zEXz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161211233845.GE27291>