Date: Sat, 24 May 2003 16:44:15 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: freebsd-alpha@freebsd.org Subject: Re: [FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64 Message-ID: <XFMail.20030524164415.jhb@FreeBSD.org> In-Reply-To: <20030524202652.68A9F2A7EA@canning.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24-May-2003 Peter Wemm wrote: > Luigi Rizzo wrote: > >> if (cmd->opcode == O_LOG) >> cmd += F_LEN(cmd); >> +#ifdef I386 >> fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr; >> +#else >> + bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs)); >> +#endif >> > > This is not a 'reviewed-by:', but these should be #ifdef __i386__ > rather than #ifdef I386. Why is the #ifdef even there? Why not use bcopy all the time? -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030524164415.jhb>