Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 05 Jan 2011 21:57:03 -0600
From:      Nathan Whitehorn <nwhitehorn@freebsd.org>
To:        Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r217041 - user/nwhitehorn/bsdinstall/partedit
Message-ID:  <4D253D8F.6080408@freebsd.org>
In-Reply-To: <201101060356.p063u1hN001113@svn.freebsd.org>
References:  <201101060356.p063u1hN001113@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 01/05/11 21:56, Nathan Whitehorn wrote:
> Author: nwhitehorn
> Date: Thu Jan  6 03:56:01 2011
> New Revision: 217041
> URL: http://svn.freebsd.org/changeset/base/217041
>
> Log:
>    Use the newly-available "modified" attribute in gpart to determine if we
>    have to do anything. This avoids an unnecessary warning due to an EPERM
>    trying to commit/undo changes on an unmodified geom.

This was the wrong commit message. It should have been:
Revert changes to all modified gparts if the user elects not to save 
changes.
-Nathan

> Modified:
>    user/nwhitehorn/bsdinstall/partedit/partedit.c
>
> Modified: user/nwhitehorn/bsdinstall/partedit/partedit.c
> ==============================================================================
> --- user/nwhitehorn/bsdinstall/partedit/partedit.c	Thu Jan  6 03:36:04 2011	(r217040)
> +++ user/nwhitehorn/bsdinstall/partedit/partedit.c	Thu Jan  6 03:56:01 2011	(r217041)
> @@ -99,6 +99,7 @@ main(void) {
>   				error = apply_changes(&mesh);
>   				break;
>   			} else if (op == 3) { /* Don't save =>  Quit */
> +				gpart_revert_all(&mesh);
>   				error =	-1;
>   				break;
>   			}




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D253D8F.6080408>