Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Jul 2003 17:12:49 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        Peter Wemm <peter@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/contrib/tar/src tar.c
Message-ID:  <20030723171139.I40342@root.org>
In-Reply-To: <20030724000408.E479E37B481@hub.freebsd.org>
References:  <20030724000408.E479E37B481@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Jul 2003, Peter Wemm wrote:
>   Fix an annoying bug in tar.  When it converted 'tar zcf' to 'tar -z -c -f'
>   it forgot to null terminate the new argv[] array.  If you mixed this
>   with $TAR_OPTIONS, phkmalloc and a whole bunch of other variables, you
>   could end up with a segfault.  This isn't strictly a phkmalloc victory
>   since tar walks off the end of an array rather than use uninitialized
>   malloc memory, but phkmalloc makes it easier to provoke.
>
>   Revision  Changes    Path
>   1.3       +4 -1      src/contrib/tar/src/tar.c

It is a victory for the Peter Murphy field though since without it, we
would never have triggered this bug.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030723171139.I40342>