Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jun 2021 09:31:06 GMT
From:      Dmitry Chagin <dchagin@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: e1e6daa8cf8e - stable/12 - linux: silence renameat2 flags warning
Message-ID:  <202106100931.15A9V6VE030587@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by dchagin:

URL: https://cgit.FreeBSD.org/src/commit/?id=e1e6daa8cf8e385a0c94c5275296252488646615

commit e1e6daa8cf8e385a0c94c5275296252488646615
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2020-10-26 18:03:50 +0000
Commit:     Dmitry Chagin <dchagin@FreeBSD.org>
CommitDate: 2021-06-10 09:28:35 +0000

    linux: silence renameat2 flags warning
    
    Hogs the console while building the Linux kernel in a Ubuntu Focal jail.
    
    (cherry picked from commit fe76bef462048f9beb3bffd448ae1adb01969594)
---
 sys/compat/linux/linux_file.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sys/compat/linux/linux_file.c b/sys/compat/linux/linux_file.c
index 0b7efb6fa964..ae7dbe76c96d 100644
--- a/sys/compat/linux/linux_file.c
+++ b/sys/compat/linux/linux_file.c
@@ -715,8 +715,16 @@ linux_renameat2(struct thread *td, struct linux_renameat2_args *args)
 		    args->flags & (LINUX_RENAME_NOREPLACE |
 		    LINUX_RENAME_WHITEOUT))
 			return (EINVAL);
+#if 0
+		/*
+		 * This spams the console on Ubuntu Focal.
+		 *
+		 * What's needed here is a general mechanism to let users know
+		 * about missing features without hogging the system.
+		 */
 		linux_msg(td, "renameat2 unsupported flags 0x%x",
 		    args->flags);
+#endif
 		return (EINVAL);
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202106100931.15A9V6VE030587>