Date: Mon, 10 Jul 2000 03:40:02 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/19803: Ext2fs kld module submission Message-ID: <200007101040.DAA98619@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/19803; it has been noted by GNATS. From: Bruce Evans <bde@zeta.org.au> To: nm@web.am Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: kern/19803: Ext2fs kld module submission Date: Mon, 10 Jul 2000 20:37:20 +1000 (EST) > >Description: > Just loadable version of ext2fs driver to get rid of EXT2FS from kernel :) There is already an open PR about this (PR 14217). I think shipping GPLed modules would result in the whole kernel being covered by the GPL, so the ext2fs module would have to be built specially to keep it out of distributions. > --- ext2_readwrite.c.orig Sun Jul 9 20:39:57 2000 > +++ ext2_readwrite.c Sun Jul 9 19:52:50 2000 > @@ -48,6 +48,36 @@ > #define WRITE ext2_write > #define WRITE_S "ext2_write" > +#include <sys/param.h> > +#include <sys/systm.h> > ... This is bogus. ext2_readwrite.c is not a standalone file. It is included by ext2_vnops.c for historical reasons (the ufs version of it was once shared by ffs and lfs). The bogusness only wastes space, since ext2fs_readwite.c only contains static functions, so the functions don't conflict with the ones in ext2_vnops.c. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007101040.DAA98619>