Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Nov 2003 17:53:17 +0100
From:      Stefan Walter <sw@gegenunendlich.de>
To:        Greg Lewis <glewis@eyesbeyond.com>
Cc:        ports@freebsd.org
Subject:   Re: Rotting PRs reminder
Message-ID:  <20031106165317.GA15763@kyuzo.dunkelkammer.void>
In-Reply-To: <20031105182705.GA6342@misty.eyesbeyond.com>
References:  <20031105102325.GA5600@kyuzo.dunkelkammer.void> <20031105182705.GA6342@misty.eyesbeyond.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greg Lewis, 05.11.03, 19:27h CET:

> On Wed, Nov 05, 2003 at 11:23:25AM +0100, Stefan Walter wrote:
> > these two PRs for new ports have been around for almost four months
> > without even a single comment:
> >=20
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/54335
> > (PPower4 - Post processor for PDF presentations made with (La)TeX)
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/54372
> > (FoilTeX - a collection of LaTeX files for making foils/slides)
> >=20
> > If there's anything wrong with them, it's unlikely for me to notice
> > unless someone points it out to me - they do work for me without any
> > problems.
>=20
> Looking at them briefly...

Thanks, your comments made me look up a few things I should have known
earlier.

> The FoilTeX do-extract looks suspiciously like it should be a build
> target rather than an extract.

In a way, the process also looks like an extraction to me, but I don't
mind; it's a do-build now.

> Both ports look like you could use %%EXAMPLESDIR%% and %%DOCSDIR%% in
> the packing list.

Did that, plus a few more of those.

> Why is mktexlsr not just run during post-install instead of printing
> a message saying one should do so?

You're right, I changed that, too. It still has to be done manually when
installing via pkg_add, though, so I kept the message.

> The PPower4 port should install its JAR in JAVAJARDIR, as defined by
> bsd.java.mk.

It now does. I didn't know about that one.

The new shar files are attached to the PRs now.

> > While we're at it, this third PR is a plain update of lang/mmix to the
> > latest version - no compile time or plist changes:
> >=20
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/57863
>=20
> Committed.  This one was assigned to a committer up until a couple
> days ago, so its unlikely anyone would have looked at it until then.

Thanks. Yes, I was aware of that. I just wanted to point out that the
patch shouldn't cause much work for a committer.

Stefan

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iQGVAwUBP6p8fVaRERsSueCzAQKS1Qv+O77AquR7t9aZqQSSXSg4gMDD2jKYn12C
YooLycRYIyy/ntK7xw9cTrCr7zdb/nS+NT+q2ClPJTFtHE0R701/UptwlmmqhWjw
R5llf5fErHu9cCCcrvuOqxjh76eojuqfSJpS6F2tEO49EzWRqQeKC5Dt2VOe92mP
ESdyx/z4nekw+2gJXsBbupvMaDlpuLzf1wzA2EjNWxbWxZp1MoyQP0b24ghU8I7f
cRNELhpYwKt3lRLrvAvuROTdL/I/+VDDCAMTZ1T+yRzUVTZvNyWZ7FZLOLj/iqPZ
m/K+nv/tdXTYGAlUsDmWDWHYj0uMoR/E9GJuJoSkMOWHV91TKVpIuVZoDteisf/q
S645MTO6m6yHxNUnsZEItrEq9y5fj4PL6OouFmnnaMbvhODdkfME+W4ojIcBTztA
oIAk4++viXEKvHJZemoeBVkYvNEMLaywH8ac9R1XZi8DiCt8LrFSTc0hl9KPUv1E
y0C9DcJNq86GtDaRU8Vm+ZRYBbiA8vlo
=3OtA
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031106165317.GA15763>