Date: Mon, 16 Jan 2012 18:38:12 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Ruslan Mahmatkhanov <rm@freebsd.org> Cc: cvs-ports@freebsd.org, Veniamin Gvozdikov <g.veniamin@googlemail.com>, Axel Gonzalez <loox@e-shell.net>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp Message-ID: <201201161838.12941.makc@freebsd.org> In-Reply-To: <201201130338.q0D3cMgJ018062@repoman.freebsd.org> References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-00=_U6GFPpKEjlBiHbb
Content-Type: Text/Plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote:
> rm 2012-01-13 03:38:22 UTC
>
> FreeBSD ports repository
>
> Modified files:
> audio/clementine-player Makefile
> Added files:
> audio/clementine-player/files patch-src-devices-cddadevice.h
> patch-src-devices-cddalister.cpp
> Log:
> - let it build with stock gcc
> - optionify ipod and mtp support (default on)
This type of `port optionification' leads to a nasty problem of hidden
dependencies when options are unchecked, but corresponding libraries are
presented. Please consider to commit the patch, which makes optional support
really optional.
Max
> PR: 164043
> Submitted by: Axel Gonzalez <loox at e-shell dot net>
> Approved by: maintainer
>
> Revision Changes Path
> 1.13 +14 -13 ports/audio/clementine-player/Makefile
> 1.1 +15 -0
> ports/audio/clementine-player/files/patch-src-devices-cddadevice.h (new)
> 1.1 +16 -0
> ports/audio/clementine-player/files/patch-src-devices-cddalister.cpp (new)
--Boundary-00=_U6GFPpKEjlBiHbb
Content-Type: text/x-patch; charset="UTF-8"; name="clementine-player.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="clementine-player.diff"
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/clementine-player/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile 13 Jan 2012 03:38:22 -0000 1.13
+++ Makefile 16 Jan 2012 18:07:01 -0000
@@ -54,14 +54,20 @@
.if defined(WITH_LASTFM)
LIB_DEPENDS+= lastfm.0:${PORTSDIR}/audio/liblastfm
+.else
+CMAKE_ARGS+= -DENABLE_LIBLASTFM=Off
.endif
.if defined(WITH_GPOD)
LIB_DEPENDS+= gpod.7:${PORTSDIR}/audio/libgpod
+.else
+CMAKE_ARGS+= -DENABLE_LIBGPOD=Off
.endif
.if defined(WITH_MTP)
LIB_DEPENDS+= mtp.11:${PORTSDIR}/audio/libmtp
+.else
+CMAKE_ARGS+= -DENABLE_LIBMTP=Off
.endif
.include <bsd.port.post.mk>
--Boundary-00=_U6GFPpKEjlBiHbb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201161838.12941.makc>