Date: Tue, 14 May 2002 14:23:52 +0100 From: Doug Rabson <dfr@nlsystems.com> To: Luigi Rizzo <luigi@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Message-ID: <200205141423.52986.dfr@nlsystems.com> In-Reply-To: <200205122043.g4CKhod56192@freefall.freebsd.org> References: <200205122043.g4CKhod56192@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 12 May 2002 9:43 pm, Luigi Rizzo wrote: > luigi 2002/05/12 13:43:50 PDT > > Minor cleanup of the code, in some places moving the indentation to 4 > spaces because the code was becoming too deep. Eventually, in a > separate commit, I will move the whole file to 4 space indent. Please back this out. All kernel code should at least attempt to conform to style(9) and this change gratuitously moves away from that standard. I don't care about anyone's personal preferences here, we are trying to keep as much kernel code as possible working to a given style. If a function is indented so deeply that it can't be represented in 80 columns, then it seriously needs re-working, IMHO. By the way, for my own personal code, I don't particularly like the 8 space indent and I am also guilty of commiting code with 4 space indents (all of which is now re-formatted, I think). Again, this is not about personal preferences, its about project-wide style. -- Doug Rabson Mail: dfr@nlsystems.com Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205141423.52986.dfr>