Date: Tue, 14 Nov 2017 16:12:05 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r454171 - head/multimedia/libvpx Message-ID: <8tf8-hp2y-wny@FreeBSD.org> In-Reply-To: <20171114110244.GB56721@FreeBSD.org> (Alexey Dokuchaev's message of "Tue, 14 Nov 2017 11:02:44 %2B0000") References: <201711141014.vAEAEjpT071974@repo.freebsd.org> <20171114102535.GA56721@FreeBSD.org> <tvxx-jg27-wny@FreeBSD.org> <20171114110244.GB56721@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev <danfe@FreeBSD.org> writes: > On Tue, Nov 14, 2017 at 11:44:00AM +0100, Jan Beich wrote: > >> Alexey Dokuchaev <danfe@FreeBSD.org> writes: >> > Actually, could you add a real 2319-byte patch file under files/ instead? >> > Last time I wanted to build some older version of `devel/android-tools-adb' >> > which has the same "bug" and could not because the patch was no longer >> > fetchable. Thank you, >> >> Why it wasn't fetchable? The GitHub mirror should be identical and is >> already used to fetch the main distfile. Provide more details. > > cd /usr/ports/devel/android-tools-adb > svn up -r424893 . > make > ... > => Attempting to fetch https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch > fetch: https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch: size unknown > fetch: https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch: size of remote file is not known > b4cff495a1f9.patch 2084 B 6281 kBps 00m00s > => Fetched file size mismatch (expected 2066, actual 2084) "git format-patch" from Git 2.11 or later honors commit abbreviation. No wonder it affects .patch links from GitHub. cf. https://github.com/git/git/commit/e6c587c733b4 >> I use PATCHFILES to denote unmodified fixes from upstream. Putting them >> under files/ requires generating with --no-prefix and pacifying portlint >> via "make makepatch". That'd be no fun if more than one patch touches >> the same files. > > I don't think that this is more important than being unable to svn up > to some past revision and having to play tricks with -DNO_CHECKSUM and > hoping everything will be OK and it's just stupid GitHub changed their > output again. That's optimistic for ports that specify only 7-hexdigits in GH_TAGNAME or vanishing MASTER_SITES. Not to mention, partial downgrades have never been supported because Mk/* bits provide limited backward compatibility.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8tf8-hp2y-wny>