Date: Wed, 23 May 2007 01:03:24 +0900 From: Takeharu KATO <takeharu1219@ybb.ne.jp> To: Marius Nuennerich <marius.nuennerich@gmx.net> Cc: freebsd-acpi@FreeBSD.org Subject: Re: kern/112544: [acpi] [patch] Add High Precision Event Timer Driver for userland timer facility Message-ID: <4653144C.2020601@ybb.ne.jp> In-Reply-To: <200705211400.l4LE0CE0057099@freefall.freebsd.org> References: <200705211400.l4LE0CE0057099@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Thank you for your review, I'll fix following issue. Marius Nuennerich wrote: > I haven't read the whole patch yet. > To me line 164 (of the first patch file) seems bogus. It tries to do > the right thing (read-modify-write) but actually does not. > HPET_OFFSET_ENABLE is the offset in the hpet datastructure. > > Should be like this: > val = bus_read_4(sc->mem_res, HPET_OFFSET_ENABLE); > bus_write_4(sc->mem_res, HPET_OFFSET_ENABLE, val | 1); > > And 1 should better HPET_ENABLE_ENABLE. > > Line 133 of the same patch does not even try to do a read-modify-write. > However the documentation is clear that it should. > > This all applies to the driver in -current (1.8) as well. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4653144C.2020601>