Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Sep 2014 09:38:37 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Bryan Drewery <bdrewery@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r272032 - head/sys/conf
Message-ID:  <1598020.ur8YbI6DkF@ralph.baldwin.cx>
In-Reply-To: <201409231704.s8NH4Lcv098184@svn.freebsd.org>
References:  <201409231704.s8NH4Lcv098184@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, September 23, 2014 05:04:21 PM Bryan Drewery wrote:
> Author: bdrewery
> Date: Tue Sep 23 17:04:21 2014
> New Revision: 272032
> URL: http://svnweb.freebsd.org/changeset/base/272032
> 
> Log:
>   DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it.
>   fstat(1) now uses libprocstat(9).  There is no userland impact to using
> this.

As your followup noted, it does change the size of 'struct lock' (and thus
'struct vnode') still.  While fstat does not use it for live, it probably
still uses it for coredumps.  However, lsof uses kvm access, so it will break.
I don't think that is worth noting here, but more of an FYI.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1598020.ur8YbI6DkF>