Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Nov 2019 22:43:11 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r354697 - head/usr.sbin/cpucontrol
Message-ID:  <201911132243.xADMhBu4007440@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Nov 13 22:43:11 2019
New Revision: 354697
URL: https://svnweb.freebsd.org/changeset/base/354697

Log:
  cpucontrol: print more useful information when MSR access fails.
  
  Instead of providing ioctl cmd value, which has no meaning to user,
  print MSR number.  The later is what the user expects in this place
  even.
  
  Reported by:	pstef
  Sponsored by:	The FreeBSD Foundation
  MFC after:	3 days

Modified:
  head/usr.sbin/cpucontrol/cpucontrol.c

Modified: head/usr.sbin/cpucontrol/cpucontrol.c
==============================================================================
--- head/usr.sbin/cpucontrol/cpucontrol.c	Wed Nov 13 22:39:46 2019	(r354696)
+++ head/usr.sbin/cpucontrol/cpucontrol.c	Wed Nov 13 22:43:11 2019	(r354697)
@@ -307,7 +307,7 @@ do_msr(const char *cmdarg, const char *dev)
 	}
 	error = ioctl(fd, command, &args);
 	if (error < 0) {
-		WARN(0, "ioctl(%s, CPUCTL_%s (%lu))", dev, command_name, command);
+		WARN(0, "ioctl(%s, CPUCTL_%s (%#x))", dev, command_name, msr);
 		close(fd);
 		return (1);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911132243.xADMhBu4007440>