Date: Mon, 24 Apr 2017 15:37:29 -0600 From: Adam Weinberger <adamw@adamw.org> To: Marius Strobl <marius@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r439345 - in head/sysutils/cdrdao: . files Message-ID: <627E45C6-8463-4EC2-93F5-0246C4122059@adamw.org> In-Reply-To: <201704242023.v3OKNN8q058653@repo.freebsd.org> References: <201704242023.v3OKNN8q058653@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 24 Apr, 2017, at 14:23, Marius Strobl <marius@FreeBSD.org> wrote: >=20 > Author: marius > Date: Mon Apr 24 20:23:23 2017 > New Revision: 439345 > URL: https://svnweb.freebsd.org/changeset/ports/439345 >=20 > Log: > - Move the inclusion of bsd.port.pre.mk up slightly so ${UNAME} is = also > available in the gcdmaster slave port at the required point in time > (it's unclear why this was no problem with the cdrdao port before). = [1] Because you didn't add the !=3D until r439255. Using !=3D is almost = always a bad thing in a port Makefile. Why aren't you using ${ARCH}? # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?627E45C6-8463-4EC2-93F5-0246C4122059>