Date: Tue, 19 Oct 2004 06:16:25 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Scott Long <scottl@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <Pine.NEB.3.96L.1041019061522.47572O-100000@fledge.watson.org> In-Reply-To: <200410190239.i9J2dRF8029843@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nice catch. I suspect we have a few more things like this floating around... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research On Tue, 19 Oct 2004, Scott Long wrote: > scottl 2004-10-19 02:39:27 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Use an alignment of 1 instead of PAGE_SIZE for the rx and tx buffer tags. > Since the e1000 DMA engines hava no constraints on the alignment of buffer > transfers, there is no reason to tell busdma that there is. This save a > minimum of 1 malloc call per packet, which translates to eliminating 4 locks. > It also means that buffers are not needlessly bounced when transfered. The > end result is a 38% improvement in pps in a 4 way bridging environment. > > Obtained from: Sandvine, Inc. > > Revision Changes Path > 1.48 +2 -12 src/sys/dev/em/if_em.c >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1041019061522.47572O-100000>