Date: Fri, 13 May 2016 02:58:59 +0100 From: Miguel C <miguelmclara@gmail.com> To: =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6knIChyb2dlci5wYXVAY2l0cml4LmNvbSk=?= <roger.pau@citrix.com> Cc: Stephen Jones <StephenJo@livingcomputermuseum.org>, "freebsd-xen@freebsd.org" <freebsd-xen@freebsd.org>, Wei Liu <wei.liu2@citrix.com> Subject: Re: xn ethernet issues as DOMU under NetBSD DOM0 FIXED! Message-ID: <CADGo8CXix6yqxFJD_xkkLP-ua6sYd_ddw4NFwAe%2BCj-nVVNqZg@mail.gmail.com> In-Reply-To: <20160512162247.64x5hyud5i2jfgqy@mac> References: <C4D720DD281F6740AC917B82741E9AD2AB27EC33@505MBX1.corp.vnw.com> <20160512162247.64x5hyud5i2jfgqy@mac>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 12, 2016 at 5:22 PM, 'Roger Pau Monn=C3=A9' (roger.pau@citrix.c= om) < roger.pau@citrix.com> wrote: > On Thu, May 12, 2016 at 02:13:03PM +0000, Stephen Jones wrote: > > Roger writes: > > > > > I think I have found what's causing the issue, but I don't have a > NetBSD > > > Dom0 in order to test the fix, could some of you please test the > following patch and report back: > > > > > > > > > > https://people.freebsd.org/~royger/0001-xen-netfront-fix-feature-detectio= n.patch > > > > > > It should apply cleanly against FreeBSD HEAD. > > > > --- a/sys/dev/xen/netfront/netfront.c > > +++ b/sys/dev/xen/netfront/netfront.c > > @@ -2016,7 +2016,7 @@ xn_query_features(struct netfront_info *np) > > device_printf(np->xbdev, "backend features:"); > > > > if (xs_scanf(XST_NIL, xenbus_get_otherend_path(np->xbdev), > > - "feature-sg", NULL, "%d", &val) < 0) > > + "feature-sg", NULL, "%d", &val) !=3D 0) > > val =3D 0; > > > > np->maxfrags =3D 1; > > @@ -2026,7 +2026,7 @@ xn_query_features(struct netfront_info *np) > > } > > > > if (xs_scanf(XST_NIL, xenbus_get_otherend_path(np->xbdev), > > - "feature-gso-tcpv4", NULL, "%d", &val) < 0) > > + "feature-gso-tcpv4", NULL, "%d", &val) !=3D 0) > > val =3D 0; > > > > np->xn_ifp->if_capabilities &=3D ~(IFCAP_TSO4|IFCAP_LRO); > > > > FreeBSD freebsd 11.0-CURRENT FreeBSD 11.0-CURRENT #1: Thu May 12 > 13:48:47 UTC 2016 root@freebsd:/usr/src/sys/amd64/compile/SDF amd64 > > > > xn0: flags=3D8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu = 1500 > > options=3D3<RXCSUM,TXCSUM> > > ether 00:16:3e:00:00:30 > > inet 192.94.73.150 netmask 0xffffff00 broadcast 192.94.73.255 > > nd6 options=3D29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL> > > media: Ethernet manual > > status: active > > > > xn0: <Virtual Network Interface> at device/vif/0 on xenbusb_front0 > > xn0: Ethernet address: 00:16:3e:00:00:30 > > xn0: backend features: > > xn0: link state changed to DOWN > > xn0: link state changed to UP > > > > Indeed this does fix the issue. I am now able to ssh into a FreeBSD 11 > DOMU running on a NetBSD DOM0. > > I've done some basic in/out transfers over sftp and rates look good, no > errors. > > > > Thank you for putting in an effort to get this working. I hope that > your diff will be incorporated quickly into > > FreeBSD 11 and backported where that can be done. > > Done, it's committed to HEAD: > > https://svnweb.freebsd.org/base?view=3Drevision&revision=3D299542 > > And I plan to backport it to stable/10 in 3 days. > > Thanks for testing it! > > FYI I patch local 10.3 system and works fine as expected, with better network performance then 9.3 At least according to iperf3 Connecting to host 10.x.x.x, port 5201 [ 4] local 10.x.x.67 port 54607 connected to 10.x.x.x port 5201 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 177 MBytes 1.48 Gbits/sec 0 94.0 MBytes [ 4] 1.00-2.00 sec 192 MBytes 1.61 Gbits/sec 0 138 MBytes [ 4] 2.00-3.00 sec 200 MBytes 1.68 Gbits/sec 0 186 MBytes [ 4] 3.00-4.00 sec 222 MBytes 1.86 Gbits/sec 0 230 MBytes [ 4] 4.00-5.00 sec 227 MBytes 1.91 Gbits/sec 0 274 MBytes [ 4] 5.00-6.00 sec 209 MBytes 1.75 Gbits/sec 0 318 MBytes [ 4] 6.00-7.00 sec 212 MBytes 1.78 Gbits/sec 0 366 MBytes [ 4] 7.00-8.00 sec 215 MBytes 1.81 Gbits/sec 0 389 MBytes [ 4] 8.00-9.00 sec 220 MBytes 1.85 Gbits/sec 0 452 MBytes [ 4] 9.00-10.00 sec 235 MBytes 1.97 Gbits/sec 0 489 MBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 2.06 GBytes 1.77 Gbits/sec 0 sende= r [ 4] 0.00-10.00 sec 2.06 GBytes 1.77 Gbits/sec receiver On 9 the max I could get was 700Mb/sec (host to guest) so this is pretty nice :) Many thanks for the fix Roger Roger. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADGo8CXix6yqxFJD_xkkLP-ua6sYd_ddw4NFwAe%2BCj-nVVNqZg>