Date: Mon, 13 Nov 2017 17:21:43 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Message-ID: <bug-202192-28711-DE9SyYsiep@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-202192-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-202192-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 Guido Falsi <madpilot@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress CC| |madpilot@FreeBSD.org --- Comment #3 from Guido Falsi <madpilot@FreeBSD.org> --- Hi, The GIO part of your patch seems to be already present in the newer upstream code, even if the implementation is a little different there: https://git.xfce.org/xfce/thunar/commit/thunar/thunar-sendto-model.c?id=3D1= f5eed407c762bf7ca118e377f91c6cb1e63eb31 regarding the rest of your patch, you are removing some upstream logic and replacing it with a very simplistic condition. While I believe it works for your use case, I don't feel comfortable changi= ng it for all users in such a way without thorough testing, or at least a good understanding of why the upstream had those more complex conditions. I'll leave this open and try to study the source, time allowing, but it will take some time to figure out. Also, I don't know sshfs, and maybe it's a ve= ry specific thing. BTW have you seen the wrong behavior without this patch appear in any other filesystem besides sshfs? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202192-28711-DE9SyYsiep>