Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Jun 2000 11:19:55 -0700 (MST)
From:      "Chad R. Larson" <chad@DCFinc.com>
To:        dgilbert@velocet.ca (David Gilbert)
Cc:        freebsd-stable@FreeBSD.ORG
Subject:   Re: dc19 fructration.
Message-ID:  <200006301819.LAA07889@freeway.dcfinc.com>
In-Reply-To: <14684.42449.103888.380937@trooper.velocet.net> from David Gilbert at "Jun 30, 0 09:51:13 am"

next in thread | previous in thread | raw e-mail | index | archive | help
As I recall, David Gilbert wrote:
> I'm not 100% satisfied with the patch.  I don't understand the
> operation of SYSCTL_STRUCT() enough to make it allocatate things
> dynamically --- it probably should.  As evidenced by the printf(), it
> knows the number of interfaces it's got right before it bzero()'s the
> block to initialize it.
> 
> The biggest insult was that BDG_MAX_PORTS was defined ... and used
> elsewhere in the code, but that a static 16 entries was allocated in
> the status struct (and not range checked anywhere).

And just to preach to the converted, how long do you think it would
have taken you to get that fixed if you were running Solaris?

	-crl
--
Chad R. Larson (CRL15)   602-953-1392   Brother, can you paradigm?
chad@dcfinc.com         chad@larsons.org          larson1@home.net   
DCF, Inc. - 14623 North 49th Place, Scottsdale, Arizona 85254-2207


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006301819.LAA07889>