Date: Mon, 30 Jul 2007 15:21:44 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Dirk Meyer <dirk.meyer@dinoex.sub.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, kris@obsecurity.org Subject: Re: cvs commit: ports/german/unix-connect Makefile Message-ID: <20070730192144.GA8483@rot26.obsecurity.org> In-Reply-To: <0OWk/kcxcH@dmeyer.dinoex.sub.org> References: <k9RLS7f/Zg@dmeyer.dinoex.sub.org> <z1/R6rf/Zg@dmeyer.dinoex.sub.org> <200706261649.l5QGno2x079313@repoman.freebsd.org> <200706261649.l5QGno2x079313@repoman.freebsd.org> <20070729183445.GB90318@rot26.obsecurity.org> <z1/R6rf/Zg@dmeyer.dinoex.sub.org> <20070729220842.GA91138@rot26.obsecurity.org> <k9RLS7f/Zg@dmeyer.dinoex.sub.org> <20070730041430.GA95009@rot26.obsecurity.org> <0OWk/kcxcH@dmeyer.dinoex.sub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 30, 2007 at 08:47:03PM +0200, Dirk Meyer wrote: > Kris Kennaway schrieb:, > > > > > Probably due to PARALLEL_PACKAGE_BUILD being removed from the build > > > > environments a bit prematurely (it's spelled PACKAGE_BUILDING > > > > these days but a couple of ports including yours were still using the > > > > old name). > > > > > > This is a different issue. > > > Please do not mix them. > > > > No it's not: > > > > +# $FreeBSD: ports/german/unix-connect/Makefile,v 1.14 2006/09/05 05:08:32 dinoex Exp $ > > > > +.if defined(PARALLEL_PACKAGE_BUILD) > > +CONFIGURE_ARGS+=--with-domain=example.com > > +.endif > > > > That used to work, then it was broken accidentally by me, then instead > > of asking about why it stopped working you made some incorrect changes > > in subsequent commits. It will work again if you put that back and > > change it to test PACKAGE_BUILDING. > > Sorry, but you misread again! > > The port was broken cause of hostname returned an emnpyt string. > It did't matter if PARALLEL_PACKAGE_BUILD was set or not. Nope, hostname returns a string, it's just not a FQDN: # jexec 1041 hostname jail-64 In fact I don't think it's even possible to construct a jail without a hostname set. > --with-domain=example.com was removed in cleanup, > as this hack made no longer any sense with MANUAL_PACKAGE_BUILD. MANUAL_PACKAGE_BUILD is highly discouraged wherever possible. Please find a way to make your port buildable on pointyhat. > > Mark and others have worked on this recently. If you think there is > > something missing, please provide your constructive suggestions. > > Great, please give a a pointer where the restrictions of > the pointhat build can be read? There are notes on http://pointyhat.freebsd.org. They are in need of updating. Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070730192144.GA8483>