Date: Thu, 19 Nov 2009 14:56:44 -0800 From: Pyun YongHyeon <pyunyh@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: svn commit: r199552 - head/sys/dev/et Message-ID: <20091119225644.GU1262@michelle.cdnetworks.com> In-Reply-To: <20091119224151.GA79179@FreeBSD.org> References: <200911192145.nAJLj6KD020454@svn.freebsd.org> <20091119224151.GA79179@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 19, 2009 at 10:41:52PM +0000, Alexey Dokuchaev wrote:
> On Thu, Nov 19, 2009 at 09:45:06PM +0000, Pyun YongHyeon wrote:
> >
> > Modified: head/sys/dev/et/if_et.c
> > ==============================================================================
> > --- head/sys/dev/et/if_et.c Thu Nov 19 21:39:43 2009 (r199551)
> > +++ head/sys/dev/et/if_et.c Thu Nov 19 21:45:06 2009 (r199552)
> > @@ -76,6 +76,10 @@ MODULE_DEPEND(et, pci, 1, 1, 1);
> > MODULE_DEPEND(et, ether, 1, 1, 1);
> > MODULE_DEPEND(et, miibus, 1, 1, 1);
> >
> > +/* Tunables. */
> > +static int msi_disable = 0;
> > +TUNABLE_INT("hw.re.msi_disable", &msi_disable);
> ^^^^^
> Shouldn't it be "hw.et" instead?
>
Oops, right.
> > + msic = pci_msi_count(dev);
> > + if (bootverbose)
> > + device_printf(dev, "MSI count : %d\n", msic);
>
> Is extra space before colon really necessary here?
>
Not needed here.
Thanks for reviewing!
> ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091119225644.GU1262>