Date: Tue, 16 Dec 2003 10:05:47 +0900 From: Jun Kuriyama <kuriyama@imgsrc.co.jp> To: Robert Watson <rwatson@FreeBSD.org> Cc: jhb@FreeBSD.org Subject: Re: vn_fullpath: 0xc85e24a0 is not locked but should be Message-ID: <7my8tdzi50.wl@black.imgsrc.co.jp> In-Reply-To: <Pine.NEB.3.96L.1031211230113.2793E-100000@fledge.watson.org> References: <7m7k123dci.wl@black.imgsrc.co.jp> <Pine.NEB.3.96L.1031211230113.2793E-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Thu, 11 Dec 2003 23:14:50 -0500 (EST),
Robert Watson wrote:
> Index: procfs.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/fs/procfs/procfs.c,v
> retrieving revision 1.9
> diff -u -r1.9 procfs.c
> --- procfs.c 17 Apr 2003 22:12:12 -0000 1.9
> +++ procfs.c 12 Dec 2003 04:13:10 -0000
> @@ -70,7 +70,9 @@
> char *fullpath = "unknown";
> char *freepath = NULL;
>
> + vn_lock(p->p_textvp, LK_EXCLUSIVE | LK_RETRY, td);
> vn_fullpath(td, p->p_textvp, &fullpath, &freepath);
> + VOP_UNLOCK(p->p_textvp, 0, td);
> sbuf_printf(sb, "%s", fullpath);
> if (freepath)
> free(freepath, M_TEMP);
I'm running my box with this patch (and DEBUG_VFS_LOCKS) and it seems
fine.
--
Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
<kuriyama@FreeBSD.org> // FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7my8tdzi50.wl>