Date: Sun, 11 Mar 2001 16:14:02 +0000 (GMT) From: tmb_ports@maddog.u-net.com To: FreeBSD-gnats-submit@freebsd.org Subject: ports/25706: cronolog port fix Message-ID: <20010311161402.AB4E12E9@maddog.blackmans.org>
next in thread | raw e-mail | index | archive | help
>Number: 25706
>Category: ports
>Synopsis: update port to fix mtree problem
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Mar 11 08:20:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator: Mark Blackman
>Release: FreeBSD 4.2-STABLE i386
>Organization:
n/a
>Environment:
stable-4 system
>Description:
Following "spam" :) from Bill Fenner, I have identified that
the 'install' target in the port's own makefile calls
'install-info' itself and therefore modifies '/usr/local/info/dir'
unbeknownst to the ports system and so at 'pkg_delete' time fails
to 'install-info --delete' the info directory entry.
I have add the appropriate '@exec install-info ..' and
'@unexec install-info --delete' lines to pkg-plist.
I also noticed that a patch I submitted over a year ago
was only partially implemented as well as one that I submitted
became broken (${STRIP} is a flag not an executable now!), so
I fixed that. The binary is stripped anyway so it doesn't matter.
In summary,
a) handle info correctly
b) move to autoconf
c) remove explicit and incorrect ${STRIP} command
>How-To-Repeat:
pkg_add cronolog-1.6.1
pkg_delete cronolog-1.6.1
>Fix:
diff -ruN cronolog.bak/Makefile cronolog/Makefile
--- cronolog.bak/Makefile Sat Apr 22 11:11:57 2000
+++ cronolog/Makefile Sun Mar 11 15:48:39 2001
@@ -14,9 +14,6 @@
MAN1= cronolog.1m cronosplit.1m
-GNU_CONFIGURE= yes
-
-post-install:
- ${STRIP} ${PREFIX}/sbin/cronolog
+USE_AUTOCONF= yes
.include <bsd.port.mk>
diff -ruN cronolog.bak/pkg-plist cronolog/pkg-plist
--- cronolog.bak/pkg-plist Sat Jan 22 03:10:03 2000
+++ cronolog/pkg-plist Sun Mar 11 16:07:02 2001
@@ -1,3 +1,5 @@
+@unexec install-info --delete %D/info/cronolog %D/info/dir
info/cronolog.info
+@exec install-info %D/info/cronolog %D/info/dir
sbin/cronolog
sbin/cronosplit
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010311161402.AB4E12E9>