Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Jun 2002 10:03:07 -0700
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        Andy Farkas <andyf@speednet.com.au>
Cc:        Brooks Davis <brooks@one-eyed-alien.net>, freebsd-bugs@FreeBSD.ORG, Dan Lukes <dan@obluda.cz>
Subject:   Re: bin/39868: cleaning sbin/dump code from warnings
Message-ID:  <20020628100307.A26852@Odin.AC.HMC.Edu>
In-Reply-To: <Pine.BSF.4.33.0206281544030.32309-100000@backup.af.speednet.com.au>; from andyf@speednet.com.au on Fri, Jun 28, 2002 at 03:54:31PM %2B1000
References:  <200206270110.g5R1A4QO001789@freefall.freebsd.org> <Pine.BSF.4.33.0206281544030.32309-100000@backup.af.speednet.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help

--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 28, 2002 at 03:54:31PM +1000, Andy Farkas wrote:
> On Wed, 26 Jun 2002, Brooks Davis wrote:
>=20
> >  Thank you for submitting patches to address the warnings in this code.
>=20
> I think what Dan is doing is A Good Thing (tm).

Absolutly.

> >  Unfortunatly, you had really bad timing and the code in -current has
> >  changed significantly due to the changes required for UFS2 support.
> >  This means it is unlikely these patches will apply to -current.  They
> >  will apply to -stable, but I'm not sure what we want to do about that
> >  given that there won't be significantly development of file system
> >  changes in -stable.
>=20
> Surely the work Dan has put into these PR's makes it extremely easy for a
> committer to review the patches, then commit.
>=20
> Even though RELENG_4 is nearing its end of life and developer and
> committer time is precious, perhaps if the user community sees results
> from their work, more contributions will be made.

I was simply pointing out that due to timing problems that are no one's
fault, it's going to be hard to use these patches in a timely manner.

We don't commit directly to stable without significant cause and in
most cases fixing warnings in programs that work isn't.  Certaintly I
would encourage anyone doing warnings fixes in current to merge these
patches as appropriate to both current and stable.  For that matter,
maybe Dan want's go really get his hands dirty and try current once DP2
comes out in July.  It's shaping up pretty nicly IMO.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--6c2NcOVqGQ03X4Wi
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9HJbKXY6L6fI4GtQRAkLTAJ9gZAMaLaV9HxXVzBHn8vR6FODAkgCfb/WQ
k9b4Xcukwn8CuUYdEuiGv8Y=
=3W6t
-----END PGP SIGNATURE-----

--6c2NcOVqGQ03X4Wi--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020628100307.A26852>