Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Mar 2006 09:17:52 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Tor Egge <tegge@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern vfs_mount.c vfs_subr.c vfs_vnops.c src/sys/sys mount.h vnode.h src/sys/ufs/ffs ffs_extern.h ffs_softdep.c ffs_vfsops.c src/sys/ufs/ufs ufs_inode.c ufs_quota.c ufsmount.h
Message-ID:  <20060310081752.GC12357@garage.freebsd.pl>
In-Reply-To: <200603082343.k28Nhd7T053744@repoman.freebsd.org>
References:  <200603082343.k28Nhd7T053744@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--5G06lTa6Jq83wMTw
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 08, 2006 at 11:43:39PM +0000, Tor Egge wrote:
+> tegge       2006-03-08 23:43:39 UTC
+>=20
+>   FreeBSD src repository
+>=20
+>   Modified files:
+>     sys/kern             vfs_mount.c vfs_vnops.c vfs_subr.c=20
+>     sys/sys              vnode.h mount.h=20
+>     sys/ufs/ffs          ffs_extern.h ffs_softdep.c ffs_vfsops.c=20
+>     sys/ufs/ufs          ufs_inode.c ufs_quota.c ufsmount.h=20
+>   Log:
+>   Use vn_start_secondary_write() and vn_finished_secondary_write() as a
+>   replacement for vn_write_suspend_wait() to better account for secondar=
y write
+>   processing.
+>  =20
+>   Close race where secondary writes could be started after ffs_sync() re=
turned
+>   but before the file system was marked as suspended.
+>  =20
+>   Detect if secondary writes or softdep processing occurred during vnode=
 sync
+>   loop in ffs_sync() and retry the loop if needed.

When exactly new 'suspended' argument for ffs_sbupdate() should be set
to 1? When I call ffs_sbupdate() after calling vfs_write_suspend(),
should I set it to 1?

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--5G06lTa6Jq83wMTw
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQFEETYwForvXbEpPzQRAqutAJ96Vnizw4HDwgEP2+aV7hbNimhL1wCgnI2y
Tt1oCAyBjR1I7x3AzL3cdfg=
=En6A
-----END PGP SIGNATURE-----

--5G06lTa6Jq83wMTw--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060310081752.GC12357>