Date: Mon, 11 Aug 2008 13:06:00 -0400 From: John Baldwin <jhb@freebsd.org> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/glxsb glxsb.c glxsb_hash.c Message-ID: <200808111306.00982.jhb@freebsd.org> In-Reply-To: <200808110841.m7B8fH4m067740@repoman.freebsd.org> References: <200808110841.m7B8fH4m067740@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 11 August 2008 04:41:08 am Pawel Jakub Dawidek wrote: > pjd 2008-08-11 08:41:08 UTC > > FreeBSD src repository > > Modified files: > sys/dev/glxsb glxsb.c glxsb_hash.c > Log: > SVN rev 181593 on 2008-08-11 08:41:08Z by pjd > > - Convert sc_sessions_mtx mutex to a rwlock, so in the fast path > (glxsb_process()) we don't block others when looking for our session. > - Simplify the loop responsible for freeing sessions on detach. > - No need to drop a lock around malloc(M_NOWAIT). > - Treat ses_used as boolean. > - Avoid gotos where possible. > - Various style(9) fixes. > > Reviewed by: philip, Patrick Lamaiziere <patfbsd@davenulle.org> Would it be worthwhile to abstract the session handling out of padlock(4) and glxsb(4)? Are there other CPUs with embedded crypto that will need their own drivers that having the abstraction would make writing a driver easier? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808111306.00982.jhb>