Date: Tue, 09 Apr 2002 19:32:17 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: Nick Hibma <n_hibma@van-laarhoven.org> Cc: Josef Karthauser <joe@tao.org.uk>, Hidetoshi Shimokawa <simokawa@FreeBSD.org>, "cvs-committers@FreeBSD.org" <cvs-committers@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c scsi_da.c Message-ID: <ybswuvh17ta.wl@ett.sat.t.u-tokyo.ac.jp> In-Reply-To: <20020409102222.M374-100000@heather.van-laarhoven.org> References: <ybsy9fx1ews.wl@ett.sat.t.u-tokyo.ac.jp> <20020409102222.M374-100000@heather.van-laarhoven.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Tue, 9 Apr 2002 10:23:24 +0200 (CEST), Nick Hibma wrote: > > > The umass driver returns the error just fine. See many postings on this > > > in the appropriate mailing lists. > > > > some drives(not driver) do, but some don't. > > Don't do what? Return an error on receiving a command they don't > understand? In that case your patch doesn't solve anything as the driver > doesn't add or remove any error messages. As fas as I observed at CAM layer, my USB HDD doesn't return any (CAM or SCSI) error for READ_6, but csio->resid is still positive. > > > At the moment the 6 byte commands are converted inside the umass driver > > > to their 10 byte equivalents, so there should be no need for your patch > > > in the first place (apart from the T_RBC bits of course, which looks > > > like a good thing to me). > > > > I made this patch for SBP-II devices. > > Did you try it with the umass driver from current? No. It's really fine if current umass doesn't need quirks, because many peopole suffer from 6 bytes command problem. As for SBP-II/Firewire, I don't like to treat raw scsi commands in SBP layer, so I decided to implement it in CAM layer. I think it's nice because some SCSI like protocols(umass, sbp, iSCSI?) can share the code. /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ybswuvh17ta.wl>