Date: Wed, 01 Nov 2017 21:39:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 223314] textproc/ripgrep: expose SIMD options Message-ID: <bug-223314-13-j2665dDEwu@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-223314-13@https.bugs.freebsd.org/bugzilla/> References: <bug-223314-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223314 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187574|maintainer-approval?(petter | Flags|i.valkonen@iki.fi) | Attachment #187574|0 |1 is obsolete| | Attachment #187662| |maintainer-approval?(petter Flags| |i.valkonen@iki.fi) --- Comment #9 from Jan Beich <jbeich@FreeBSD.org> --- Created attachment 187662 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D187662&action= =3Dedit v1.1 (In reply to petteri.valkonen from comment #8) > I'm afraid I'm not familiar enough with Rust's internals to offer > any meaningful feedback on this patch. Neither me. I don't use Rust outside of firefox or ripgrep. Are you going to approve or not? The patch here can land before bug 223342. > It seems you and John have a good discussion going, though. The ports framework currently doesn't support depending on specific options= in dependencies, so individual ports work around by managing defaults or using slaves. For one, databases/sqlite3 has a number of options changing which w= ill break consumers. textproc/ripgrep depends on PORT_LLVM=3Doff in lang/rust w= hich is already default, so this is mostly FYI. Besides, PORT_LLVM maybe dropped= if it proves to be hard to maintain such as more Rust features start to depend= on APIs specific to bundled LLVM. > I'd like to see the RUSTC_BOOTSTRAP=3D1 hack be better documented in > the Makefile itself (i.e. why is it needed?), and not just be > mentioned in passing in the PR. "# cheat Nightly requirement" wasn't good enough? OK, I've made it more verbose. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-223314-13-j2665dDEwu>