Date: Tue, 13 May 2003 14:35:00 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Scott Long <scott_long@btc.adaptec.com> Cc: re@FreeBSD.org Subject: Re: sysinstall non-USB mouse dialog confusing Message-ID: <XFMail.20030513143500.jhb@FreeBSD.org> In-Reply-To: <3EC00853.1000102@btc.adaptec.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-May-2003 Scott Long wrote:
> John Baldwin wrote:
>> On 12-May-2003 John Baldwin wrote:
>>
>>>>Enable support for a PS/2 (non-USB) mouse? Yes [No]
>>>
>>>Perhaps the dialog should be reworded to say 'PS/2, Serial, or Bus mouse'.
>>
>>
>> Index: install.c
>> ===================================================================
>> RCS file: /usr/cvs/src/usr.sbin/sysinstall/install.c,v
>> retrieving revision 1.341
>> diff -u -r1.341 install.c
>> --- install.c 20 Apr 2003 14:08:04 -0000 1.341
>> +++ install.c 12 May 2003 18:33:54 -0000
>> @@ -662,7 +662,7 @@
>>
>> #ifdef WITH_MICE
>> dialog_clear_norefresh();
>> - if (!msgNoYes("Does this system have a non-USB mouse attached to it?"))
>> + if (!msgNoYes("Does this system have a PS/2, serial, or bus mouse?"))
>> dmenuOpenSimple(&MenuMouse, FALSE);
>> #endif
>>
>> Does this make everyone happy with the mouse question?
>>
>
> Yes. My gut feeling is to also
So is the above diff approved?
> 1) default the above dialog to TRUE,
If someone else wants to change it go ahead. I don't know why Jordan
chose a default of no for this. Probably because server's usually
don't have mice.
> 2) allow ubsd to be toggled in the 'Startup Services' menu, with the
> default to TRUE. Hell, usbd isn't nearly as annoying as sendmail!
Well, the default should be whatever sysinstall currently detects. It
could be added to the menu easily enough. Oh, wait, it's already
there, and has been for about a year and a half:
revision 1.322
date: 2001/09/05 00:58:28; author: murray; state: Exp; lines: +5 -1
Allow users to enable usbd and set flags from sysinstall. This is
useful for post install configuration or other cases that might not be
handled by usb.c. (usb.c already sets usbd_enable iff sysinstall
detects usb during install).
PR: bin/18946
Submitted by: Peter van Heusden <pvh@egenetics.com>
Reviewed by: jhb
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030513143500.jhb>