Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Jun 2010 23:30:44 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 179197 for review
Message-ID:  <201006042330.o54NUif6060111@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@179197?ac=10

Change 179197 by hselasky@hselasky_laptop001 on 2010/06/04 23:30:41

	
	USB core:
		- add support for LOW speed BULK transfers.
		- this mode is not recommended by the USB 2.0
		  standard, though some USB devices use it
		  anyway.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#53 edit
.. //depot/projects/usb/src/sys/dev/usb/controller/ohci.c#35 edit
.. //depot/projects/usb/src/sys/dev/usb/controller/uhci.c#32 edit
.. //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#177 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#53 (text+ko) ====

@@ -3792,9 +3792,7 @@
 			}
 			break;
 		case UE_BULK:
-			if (udev->speed != USB_SPEED_LOW) {
-				ep->methods = &ehci_device_bulk_methods;
-			}
+			ep->methods = &ehci_device_bulk_methods;
 			break;
 		default:
 			/* do nothing */

==== //depot/projects/usb/src/sys/dev/usb/controller/ohci.c#35 (text+ko) ====

@@ -2614,9 +2614,7 @@
 			}
 			break;
 		case UE_BULK:
-			if (udev->speed != USB_SPEED_LOW) {
-				ep->methods = &ohci_device_bulk_methods;
-			}
+			ep->methods = &ohci_device_bulk_methods;
 			break;
 		default:
 			/* do nothing */

==== //depot/projects/usb/src/sys/dev/usb/controller/uhci.c#32 (text+ko) ====

@@ -3068,9 +3068,7 @@
 			}
 			break;
 		case UE_BULK:
-			if (udev->speed != USB_SPEED_LOW) {
-				ep->methods = &uhci_device_bulk_methods;
-			}
+			ep->methods = &uhci_device_bulk_methods;
 			break;
 		default:
 			/* do nothing */

==== //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#177 (text+ko) ====

@@ -3057,7 +3057,7 @@
 	};
 
 	static const uint16_t bulk_min[USB_SPEED_MAX] = {
-		[USB_SPEED_LOW] = 0,	/* not supported */
+		[USB_SPEED_LOW] = 8,
 		[USB_SPEED_FULL] = 8,
 		[USB_SPEED_HIGH] = 512,
 		[USB_SPEED_VARIABLE] = 512,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006042330.o54NUif6060111>