Date: Tue, 14 Jan 2003 02:55:12 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Sheldon Hearn <sheldonh@starjuice.net> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/dump Makefile cache.c dump.8 dump.h main.c traverse.c Message-ID: <200301141055.h0EAtC2Y079386@apollo.backplane.com> References: <200301131942.h0DJgfbN010760@repoman.freebsd.org> <20030114100821.GE61405@starjuice.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Well, the NetBSD specification is aweful. I would never impose it
on our poor sysops! It's completely non-obvious and you need a
calculator to figure out how large a cache you want. It's in multiples
of the 'readblksize', which defaults to 32K. I don't know WHAT they
were thinking!
So what I did was use a different option, -C, specified in megabytes of
cache, and left -r open. We can always implement a compatible -r and
list -C as being FreeBSD specific, but I don't see any particular pressing
need to maintain compatibility with NetBSD's option set here (if only they
had chosen more reasonable units!).
In anycase, the code is self contained so it does not interfere with any
of my other work, I can leave it in my -stable tree 2 weeks no problem.
But unless someone comes up with a bright idea that lets us get the best
of both, it's going to be -C.
-Matt
Matthew Dillon
<dillon@backplane.com>
:First, let me say that this looks very cool.
:
:> MFC after: 3 days
:
:However, I'd like you to wait with respect to merging.
:
:I don't want this option to hit production lines until it's clear that
:the compatibility camp is okay with offering similar functionality to
:that found in NetBSD, without using the same option.
:
:For example, if OpenBSD also add NetBSD's -r, then we're the odd man
:out. If the only justification is the one you gave in your commit log
:(megabytes are easier to work with than 512 byte blocks), then I suspect
:it might be worthwhile to get in line with NetBSD before merging.
:
:So could you hold off for, say 2 weeks, before merging? I think this
:will allow enough time for the issue to be discussed and resolved.
:
:Ciao,
:Sheldon.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301141055.h0EAtC2Y079386>